Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libcore
andliblocation
modulesThe interesting part to get ☝️ working is
mapbox-events-android/libcore/build.gradle
Lines 24 to 28 in fe86ffd
We're telling Gradle to include the classes from the
libcore
(itself) and from theliblocation
module. So we're telling it explicitly which classes form the artifact and because of that we don't need to includecompile project(':liblocation')
anymore. A drawback of doing it this way is that we need to includemapbox-events-android/libcore/build.gradle
Lines 32 to 34 in fe86ffd
in both
libcore
andliblocation
modules because if not Gradle doesn't know to resolveliblocation
classes and throws compile errors.It's a bit hacky but it's working ¯\_(ツ)_/¯
What do you think? Any thoughts?
👀 @zugaldia @electrostat @cammace