Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

circle type layer radius isn't styled by pixel value at high zoom levels #1446

Closed
samanpwbb opened this issue Aug 31, 2015 · 1 comment
Closed

circle type layer radius isn't styled by pixel value at high zoom levels #1446

samanpwbb opened this issue Aug 31, 2015 · 1 comment
Assignees
@ansis
Labels
bug 🐞

Comments

@samanpwbb
Copy link
Contributor

zoom level 8:
screen shot 2015-08-31 at 12 21 24 pm

zoom level 16:
screen shot 2015-08-31 at 12 21 16 pm

Here's my stylesheet:

{
    "version": 8,
    "name": "circle-bug",
    "sources": {
        "mapbox://saman-staging2.4kvf8j52": {
            "url": "mapbox://saman-staging2.4kvf8j52",
            "type": "vector"
        }
    },
    "layers": [
        {
            "interactive": true,
            "minzoom": 0,
            "layout": {
                "visibility": "visible"
            },
            "metadata": {},
            "maxzoom": 22,
            "type": "circle",
            "source": "mapbox://saman-staging2.4kvf8j52",
            "id": "gaz",
            "paint": {
                "circle-radius": 5
            },
            "source-layer": "gaz"
        }
    ],
    "created": "2015-08-31T16:11:47.260Z",
    "id": "ce9a6770",
    "modified": "2015-08-31T16:22:13.977Z",
    "owner": "saman-staging2"
}

Using this datasource: http://cl.ly/3e2n3q1Z1f14
@samanpwbb samanpwbb changed the title circle type layers aren't styled by pixel value at high zoom levels circle type layer radius isn't styled by pixel value at high zoom levels Aug 31, 2015
@jfirebaugh
Copy link
Contributor

What does "styled by pixel value" mean? What exactly was different from what you expected?

@ansis ansis self-assigned this Aug 31, 2015
ansis added a commit to mapbox/mapbox-gl-test-suite that referenced this issue Sep 2, 2015
@ansis
update circle tests
023eb95 
for mapbox/mapbox-gl-js#1446
@ansis ansis closed this as completed in 5c8be4b Sep 2, 2015
@incanus incanus mentioned this issue Oct 28, 2015
Open
lucaswoj pushed a commit that referenced this issue Dec 13, 2016
@ansis
fix #1446
f8ee9ce 
The pos coordinates still included part of the extrude. The positions
for drawing the vertices on the right side were offset to the right by
0.5. This is a really tiny difference, but if you zoom in far enough it
makes the circle bigger than it should be.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ansis ansis

Labels
bug 🐞
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jfirebaugh @samanpwbb @ansis