Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollover effect with 0.45 #6290

Closed
phiphou opened this issue Mar 7, 2018 · 3 comments
Closed

Rollover effect with 0.45 #6290

phiphou opened this issue Mar 7, 2018 · 3 comments

Comments

@phiphou
Copy link

phiphou commented Mar 7, 2018

I re-open #6278 because I don't understand the answer.

I want to be able to have multiple markers, not overlapping, and a rollover effect on either the markers or the text of the markers when displayed

Here is a sample : https://jsfiddle.net/d8qs32pw/15/ (zoom on the marker to see the second one)

It worked fine with v0.41 and older versions.

I know there is a bug with text-offset in #6146

@jfirebaugh told me to set icon-ignore-placement and text-ignore-placement on the markers layer to true but I don't want them to be overlapped.

Setting text/icon-allow-overlap to true on the hover layer as @ChrisLoer told me does not solved the problem of the weird hovering behavior.

So, I cannot use #6163 (comment)

If possible, can you update my example or tell me if v0.45 will let me have the same behavior of v0.41

It's important for me and my clients to know witch version we can use to have this needed multiple markers (not overlapping) rollover effect.

Sorry for the flood, I know you're not stackoverflow, but I think it's currently a bug.

Please don't close this before I can check the answer correctly fits my needs (and sorry for the bad english, I'm french)

@ChrisLoer
Copy link
Contributor

Hi @phiphou, oops we've got different time-zones making it harder to talk too!

Yes, we agree it's a regression from v.41, it was introduced by the architectural changes to support "cross-source collision detection" in PR #5150. We are tracking the issue as #5836. I don't know if it will make it into the v.45 release, but I'm working on it -- and we'll keep everyone updated on that ticket. I used your fiddle to test that my proposed fix for #5836 would address your use case. I don't think you should try to use my fix yet, because it's not released yet and there's a good chance the implementation will change before release.

@phiphou
Copy link
Author

phiphou commented Mar 8, 2018

Thanks for your answer, I now understand better the problem, and will follow #5836.

For now I will stay with v0.41and wait for future releases to see when I can switch to an higher version.

@phiphou phiphou closed this as completed Mar 8, 2018
@phiphou phiphou reopened this Apr 30, 2018
@ChrisLoer
Copy link
Contributor

@phiphou We closed issue #5836 as a duplicate, but the underlying issue is still something we are working on. Although the change to Mapbox GL JS is relatively simple, the change affects many other components that rely on GL JS so there has been a lot of back-and-forth discussion. The current proposed fix is at PR #6566.

reiterbene added a commit to Wikimedia-Austria/WikiDaheim that referenced this issue Jun 28, 2018
rolled back mapbox version due to present bug, better mouseover behavior
see mapbox/mapbox-gl-js#6163
maybe it will be fixed with version 0.45. See mapbox/mapbox-gl-js#6290

fixed filterung

added in_menu parameter for static sites
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants