Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Rename mapID to styleID #1500

Closed
1ec5 opened this issue May 11, 2015 · 3 comments · Fixed by #1561
Closed

Rename mapID to styleID #1500

1ec5 opened this issue May 11, 2015 · 3 comments · Fixed by #1561
Assignees
@1ec5
Labels
iOS Mapbox Maps SDK for iOS refactor
Milestone
iOS Beta 2

Comments

@1ec5
Copy link
Contributor

1ec5 commented May 11, 2015

Per discussion with @willwhite, -[MGLMapView mapID] should be renamed -styleID for consistency with -styleURL and because the mapbox: URL scheme expands to a style API URL rather than one from the TileJSON API.

We'll need to deprecate -mapID, update documentation, and issue a warning from within designables if possible.
@incanus
Copy link
Contributor

incanus commented May 11, 2015

deprecate

Do we? We're pre-1.0 😉 I think we can run with this.

@1ec5
Copy link
Contributor Author

1ec5 commented May 11, 2015

Will anyone be using -mapID in beta 1? If so, we’ll need to either support a migration path (including deprecating -mapID) or release note the steps to migrate manually (which involve a bit of fiddling if using storyboards).

@1ec5 1ec5 added iOS Mapbox Maps SDK for iOS refactor labels May 11, 2015
@1ec5 1ec5 added this to the iOS Beta 2 milestone May 11, 2015
@incanus
Copy link
Contributor

incanus commented May 11, 2015

If we have API for setMapID:, but no non-Mapboxers with API access, we can push to b2 and just bulk rename and document.

1ec5 added a commit that referenced this issue May 14, 2015
@1ec5
mapID → styleID
00b2e13 
Deprecated `-mapID` and `-setMapID:` to accurately reflect the APIs the ID is used for. Marked the property unavailable but reimplemented its getter and setter to assert with helpful messages.

Fixes #1500.
@1ec5 1ec5 mentioned this issue May 14, 2015
Merged
@1ec5 1ec5 self-assigned this May 14, 2015
@1ec5 1ec5 removed the ready label May 21, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@1ec5 1ec5

Labels
iOS Mapbox Maps SDK for iOS refactor
Projects
None yet
Milestone
iOS Beta 2
Development

Successfully merging a pull request may close this issue.

mapID → styleID mapbox/mapbox-gl-native
2 participants
@incanus @1ec5