Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Check for View leaks #2675

Closed
ljbade opened this issue Oct 20, 2015 · 2 comments
Closed

Check for View leaks #2675

ljbade opened this issue Oct 20, 2015 · 2 comments
Assignees
@ljbade
Labels
Android Mapbox Maps SDK for Android
Milestone
android-v2.2.0

Comments

@ljbade
Copy link
Contributor

ljbade commented Oct 20, 2015

Was catching up on the Android performance videos.

This one is on leaking Views: https://www.youtube.com/watch?v=BkbHeFHn8JY

I think we hold referenced to MapView in NativeMapView, and possibly inside the JNI.

We should change these to weak references.
@ljbade ljbade added the Android Mapbox Maps SDK for Android label Oct 20, 2015
@ljbade ljbade added this to the android-v2.2.0 milestone Oct 20, 2015
@tobrun
Copy link
Member

tobrun commented Oct 20, 2015

Yep, good catch.

An example of a weak reference can be found in CompassClickListener

@ljbade
Copy link
Contributor Author

ljbade commented Oct 20, 2015

Found one leak in the code I was using to test Choreographer.

Something else is leaking too.

ljbade pushed a commit that referenced this issue Oct 20, 2015
[android] Sync GPS marker
97d193b 
Lots of other performance and memory improvements.
Fixes #2668
Fixes #2411
Fixes #2678
Fixes #2675
@ljbade ljbade mentioned this issue Oct 20, 2015
Closed
@ljbade ljbade self-assigned this Oct 20, 2015
ljbade pushed a commit that referenced this issue Oct 20, 2015
[android] Sync GPS marker
bc85f93 
Lots of other performance and memory improvements.
Fixes #2668
Fixes #2411
Fixes #2678
Fixes #2675
@ljbade ljbade mentioned this issue Oct 22, 2015
Merged
ljbade pushed a commit that referenced this issue Oct 22, 2015
[android] Implement UserLocationView
8b79a8d 
Draws animated and synced GPS marker.
Inlcudes direction arrow and accuracy ring.
Fade out the compass after a delay when reset to north.
Lots of other performance and memory improvements.
add OnMyLocationChangeListener
Move FAB with snackbar
Fix getMetersPerPixelAtLatitude
Fix some incorrect annotations
Fixes #2668
Fixes #2411
Fixes #2678
Fixes #2675
Fixes #2566
Fixes #2549
Fixes #2692
Fixes #2572
AndwareSsj pushed a commit to AndwareSsj/mapbox-gl-native that referenced this issue Nov 6, 2015
[android] Implement UserLocationView
f64079a 
Draws animated and synced GPS marker.
Inlcudes direction arrow and accuracy ring.
Fade out the compass after a delay when reset to north.
Lots of other performance and memory improvements.
add OnMyLocationChangeListener
Move FAB with snackbar
Fix getMetersPerPixelAtLatitude
Fix some incorrect annotations
Fixes mapbox#2668
Fixes mapbox#2411
Fixes mapbox#2678
Fixes mapbox#2675
Fixes mapbox#2566
Fixes mapbox#2549
Fixes mapbox#2692
Fixes mapbox#2572
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ljbade ljbade

Labels
Android Mapbox Maps SDK for Android
Projects
None yet
Milestone
android-v2.2.0
Development

No branches or pull requests
2 participants
@ljbade @tobrun