Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Release Android 2.2.0 #2847

Closed
7 tasks done
bleege opened this issue Oct 28, 2015 · 13 comments
Closed
7 tasks done

Release Android 2.2.0 #2847

bleege opened this issue Oct 28, 2015 · 13 comments
Assignees
Labels
Android Mapbox Maps SDK for Android

Comments

@bleege
Copy link
Contributor

bleege commented Oct 28, 2015

It's been just a week since the original 2.1.0 release, but we have all sorts of good stuff that we should get out into the world.

New Highlights

Full Change Log: https://github.com/mapbox/mapbox-gl-native/issues?q=is%3Aissue+milestone%3Aandroid-v2.2.0

Release Branch: https://github.com/mapbox/mapbox-gl-native/commits/release-android-v2.2.0

Here's the TODO list for making that happen:

  • Change Version Name to 2.2.0
  • Publish 2.2.0 artifact to Maven Central
  • Updating Mapbox.com JavaDoc Documentation
  • Tag android-v2.2.0 in GitHub
  • Update version info in Twitter Fabric metadata file
  • Move open issues to android-v2.3.0 Milestone in GitHub
  • Close Milestone android-v2.2.0 in GitHub

/cc @mapbox/mobile @mapbox/support @twbell

@bleege bleege added the Android Mapbox Maps SDK for Android label Oct 28, 2015
@bleege bleege self-assigned this Oct 28, 2015
@bleege bleege added this to the android-v2.2.0 milestone Oct 28, 2015
@bleege
Copy link
Contributor Author

bleege commented Oct 28, 2015

FYI @ljbade @tobrun I've moved the milestone of tickets that were associated with commits that landed in master since the release branch commit 43dde0f on 27-Oct-2015. The commits are still in master, but the milestone was changed from android-v2.2.0 to android-v2.3.0 as they won't make this release. Below is a screenshot of the affected commits intermingled with other non Android commits:

screen shot 2015-10-28 at 4 50 14 pm

@ljbade
Copy link
Contributor

ljbade commented Oct 29, 2015

@bleege Since the switch over from Marker.setSprite(String) to Marker.setIcon(Sprite) is breaking, should we go to 3.0.0?

@bleege
Copy link
Contributor Author

bleege commented Oct 29, 2015

@ljbade Can you clarify by what you mean by "breaking"? Do you mean that setSprite() was renamed to setIcon()?

@ljbade
Copy link
Contributor

ljbade commented Oct 29, 2015

@bleege It is not just a simple rename, we also have a new way of loading sprites. Instead of a string which points to the style specific sprite sheet (and was really just a temporary solution - iOS does not support this for a good reason), you now first load a Sprite via SpriteFactory.

@ljbade
Copy link
Contributor

ljbade commented Oct 29, 2015

So code using the old setSprite will need to be changed, and the app developer will have to add a Bitmap resource with the icon they want. Whether it be from Maki, or their own design.

@bleege
Copy link
Contributor Author

bleege commented Oct 29, 2015

Thanks for clarifying @ljbade. Here's what I'm thinking:

It is not just a simple rename, we also have a new way of loading sprites.

This is to be understood and fine as this is the first release were the SDK will offer custom sprite loading. It's also the second overall release of the SDK (with the first one being just a week ago). Looking at the code the impact will be limited to MarkerOptions.icon() as Marker.setIcon() is not directly accessible to developers (and has a friendly JavaDoc note to not directly use this 😃 ). The end result is that to "upgrade" will require the following change (assuming a custom Style Sprite was even specified and not just using the default):

// 2.1.0
new MarkerOptions().sprite()

// 2.2.0
new MarkerOptions().icon()

Besides, this is one of the reasons why we have have example code in MapboxGLAndroidSDKTestApp (aka "the Test App") so that people can see how things work. ;-)

In short, this is still the very early days of the SDK and API changes are to be expected. This one isn't large enough to warrant going up a full semver.

@bleege
Copy link
Contributor Author

bleege commented Oct 29, 2015

Just finished publishing 2.2.0 to Maven Central. It'll take a few hours for it to show up in http://search.maven.org/ though.

@bleege
Copy link
Contributor Author

bleege commented Oct 29, 2015

Tagged as android-v2.2.0 and pushed. Here's the commit tree for this tag:

https://github.com/mapbox/mapbox-gl-native/commits/android-v2.2.0

screen shot 2015-10-29 at 10 42 16 am

@bleege
Copy link
Contributor Author

bleege commented Oct 29, 2015

Finally landed in Maven Central --> https://repo1.maven.org/maven2/com/mapbox/mapboxsdk/mapbox-android-sdk/2.2.0/

@bleege
Copy link
Contributor Author

bleege commented Oct 29, 2015

Confirmed that 2.2.0 from Maven Central works as expected by loading into local copy of Android Demo App.

device-2015-10-29-110112

@bleege
Copy link
Contributor Author

bleege commented Oct 29, 2015

Just published the JavaDoc updates to https://www.mapbox.com/android-sdk/. Waiting for it to regenerate which should just take a few minutes.

@bleege
Copy link
Contributor Author

bleege commented Oct 29, 2015

JavaDocs are live!

Time to close this milestone and call it!

🍻

@Mansi26
Copy link

Mansi26 commented Feb 9, 2016

Hi..i am trying to center the Info window when the map is zoomed.
But ..i could not find any listener for zoom event.
Can anyone help..regarding how to do this...?
Could not find any projection class in 2.2.
Please help

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Android Mapbox Maps SDK for Android
Projects
None yet
Development

No branches or pull requests

3 participants