Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Move static packaging script into an Xcode workflow #8089

Closed
boundsj opened this issue Feb 17, 2017 · 4 comments
Closed

Move static packaging script into an Xcode workflow #8089

boundsj opened this issue Feb 17, 2017 · 4 comments
Labels
archived Archived because of inactivity build iOS Mapbox Maps SDK for iOS
Milestone

Comments

@boundsj
Copy link
Contributor

boundsj commented Feb 17, 2017

In #7773 we sidestepped an issue with packaging the iOS static build by updating the way libtool is informed about mason dependencies.

Longer term, we should move the packaging step into Xcode itself and come up with some way to test the integration of the static build in an app on CI.

cc @kkaefer @1ec5

@boundsj boundsj added build iOS Mapbox Maps SDK for iOS refactor labels Feb 17, 2017
@boundsj boundsj added this to the ios-future milestone Feb 17, 2017
@friedbunny
Copy link
Contributor

Doing the packaging of the static framework in a script is also blocking the creation of an “iosapp-static” target in our Xcode project, which would be identical to iosapp except that it would integrate the static framework (rather than the dynamic).

@1ec5
Copy link
Contributor

1ec5 commented Sep 26, 2018

In #7773 we sidestepped an issue with packaging the iOS static build by updating the way libtool is informed about mason dependencies.

Is this line still relevant, now that #12808 vendors ICU instead of pulling it in through Mason?

`cmake -LA -N ${DERIVED_DATA} | grep MASON_PACKAGE_icu_LIBRARIES | cut -d= -f2`

@kkaefer
Copy link
Member

kkaefer commented Sep 26, 2018

Nope, let's ⛏ it

@stale stale bot added the archived Archived because of inactivity label Mar 25, 2019
@stale
Copy link

stale bot commented Mar 25, 2019

This issue has been automatically detected as stale because it has not had recent activity and will be archived. Thank you for your contributions.

@stale stale bot closed this as completed Mar 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived Archived because of inactivity build iOS Mapbox Maps SDK for iOS
Projects
None yet
Development

No branches or pull requests

4 participants