This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Vendor SQLite and ICU #12808
Merged
Vendor SQLite and ICU #12808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(I committed the third-party code separately with an Anonymous author to prevent messing up the commit stats) |
10 tasks
kkaefer
force-pushed
the
vendor-sqlite-icu
branch
from
895f8d2 to
0bd182a
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By building these ourselves instead of depending on Mason-provided versions, we can tightly control what parts of the library we need, and selectively disable features to save on file size. Looks like we can save 5-7% for Android builds. On platforms where we bundle SQLite, these symbols are not accessible from outside anyway, so it should be okay to remove those features.