This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Do not overwrite user-set focal point when tracking location #10910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobrun
approved these changes
Jan 11, 2018
LukasPaczos
force-pushed
the
lp-do-not-overwrite-focal-point
branch
from
7b58e34 to
373bbf0
Compare
tobrun
pushed a commit
that referenced
this pull request
Jan 22, 2018
tobrun
pushed a commit
that referenced
this pull request
Jan 23, 2018
mappy-mobile
pushed a commit
to Mappy/mapbox-gl-native
that referenced
this pull request
Jan 25, 2018
…n_layer_changes * mapbox_release_5.3.2: [android] - rollback fragment flash changes for ViewPager support [android] - update changelog for v5.3.2 [android] - handle null Call instances in HttpRequest [android] - allow setting an OkHttpClient Camera callbacks for velocity animated movements (mapbox#10925) [android] do not overwrite user-set focal point when tracking location (mapbox#10910) [android] - retain configuration for user provided focal point and deselect markers on tap [android] - add filesource activation/deactivation to OfflineRegion status and deletion [android] - check if the render surface has been correctly created before destroying the map [android] - validate zoom level before creating mapbox telem event macos-v0.6.1 [macos] Added dates to changelog [core] update vector-tile dependency to 1.0.1 [ios] Bump podspec to v3.7.3 [ios] Fix the layout constraints on iOS 11 for iPhone X (mapbox#10858)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Up until this point, we were overwriting user-set focal point when camera's tilt was changed and location tracking was enabled. Since I'm not seeing any
MyLocationViewregressions after introducing these changes, I'm just removing the responsible call.