This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Validate zoom level before creating mapbox telem event #10959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukasPaczos
suggested changes
Jan 18, 2018
| @@ -21,24 +22,32 @@ | |||
| static Hashtable<String, Object> buildMapClickEvent( | |||
| @NonNull Location location, @NonNull String gestureId, Transform transform) { | |||
| try { | |||
| return MapboxEvent.buildMapClickEvent(location, gestureId, transform.getZoom()); | |||
| double mapZoom = transform.getZoom(); | |||
| if (mapZoom >= MapboxConstants.MAXIMUM_ZOOM && mapZoom <= MapboxConstants.MAXIMUM_ZOOM) { | |||
There was a problem hiding this comment.
We should use MapboxConstants.MINIMUM_ZOOM in the first check. Typo? ;)
There was a problem hiding this comment.
thanks for catching that!
| } | ||
|
|
||
| @Nullable | ||
| static Hashtable<String, Object> buildMapDragEndEvent( | ||
| @NonNull Location location, Transform transform) { | ||
| try { | ||
| return MapboxEvent.buildMapDragEndEvent(location, transform.getZoom()); | ||
| double mapZoom = transform.getZoom(); | ||
| if (mapZoom >= MapboxConstants.MAXIMUM_ZOOM && mapZoom <= MapboxConstants.MAXIMUM_ZOOM) { |
There was a problem hiding this comment.
MapboxConstants.MINIMUM_ZOOM missing here as well.
tobrun
force-pushed
the
invalid-zoom-level-telem
branch
from
6e3ee8f to
42c9c8b
Compare
LukasPaczos
approved these changes
Jan 22, 2018
This was referenced Jan 22, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #8057