This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[iOS] - Update telemetry certificate pinning #11845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rclee
requested review from
friedbunny,
1ec5,
fabian-guerra,
julianrex and
jmkiley
|
Looks like you’ll need to rebase this branch atop the latest release-agua commit and change the target branch to release-agua instead of master. |
|
Was hoping no-one would see that. Made the PR then saw what I did but couldn't change it because of bad train internet haha. Look good now? @1ec5 |
platform/ios/src/MGLAPIClient.m
Outdated
| @@ -4,7 +4,7 @@ | |||
| #import "MGLAccountManager.h" | |||
|
|
|||
| static NSString * const MGLAPIClientUserAgentBase = @"MapboxEventsiOS"; | |||
| static NSString * const MGLAPIClientBaseURL = @"https://events.mapbox.com"; | |||
| static NSString * const MGLAPIClientBaseURL = @"https://events.mapbox.cn"; | |||
There was a problem hiding this comment.
This library will be available for all our customers, they may download it even tho they are not in China. Is it possible to configure the URL so we don't have to hard code it?
|
After discussion with the @mapbox/maps-ios team, let's make a build with the CN endpoint instead of releasing this update broadly, to prevent accidental updates by Global customers. |
fabian-guerra
added
iOS
|
ff4c5e1 comments out some more code so that we don’t end up evaluating a certificate that hasn’t been loaded. |
1ec5
approved these changes
May 7, 2018
friedbunny
added
telemetry
friedbunny
approved these changes
May 7, 2018
fabian-guerra
pushed a commit
that referenced
this pull request
Jun 22, 2018
* Update telemetry certificate pinning * Load both CN certificates * [ios] Use China events endpoint with China API endpoint * Update CHANGELOG.md # Conflicts: # platform/ios/CHANGELOG.md # platform/ios/ios.xcodeproj/project.pbxproj # platform/ios/src/MGLAPIClient.m
fabian-guerra
pushed a commit
that referenced
this pull request
Jun 22, 2018
* Update telemetry certificate pinning * Load both CN certificates * [ios] Use China events endpoint with China API endpoint * Update CHANGELOG.md # Conflicts: # platform/ios/CHANGELOG.md # platform/ios/ios.xcodeproj/project.pbxproj # platform/ios/src/MGLAPIClient.m
rclee
added a commit
to mapbox/mapbox-events-ios
that referenced
this pull request
Jun 26, 2018
Brings in changes from mapbox/mapbox-gl-native#11860 and mapbox/mapbox-gl-native#11845
rclee
added a commit
to mapbox/mapbox-events-ios
that referenced
this pull request
Jun 27, 2018
* Add china certificates and endpoint Brings in changes from mapbox/mapbox-gl-native#11860 and mapbox/mapbox-gl-native#11845
rclee
added a commit
to mapbox/mapbox-events-ios
that referenced
this pull request
Jun 27, 2018
* Add china certificates and endpoint Brings in changes from mapbox/mapbox-gl-native#11860 and mapbox/mapbox-gl-native#11845 Set baseURL
rclee
added a commit
that referenced
this pull request
Jun 27, 2018
fabian-guerra
pushed a commit
that referenced
this pull request
Jun 27, 2018
fabian-guerra
pushed a commit
that referenced
this pull request
Jun 27, 2018
fabian-guerra
pushed a commit
that referenced
this pull request
Jun 28, 2018
fabian-guerra
pushed a commit
that referenced
this pull request
Jun 28, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is update our certificate pinning for china.