This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[core] Don't default-show text/icons that depend on the placement of a paired icon/text #12521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ChrisLoer I'll give it a try thanks! |
|
I confirm that this patch is working on iOS with our style. |
|
Thanks @RomainQuidet ! |
RomainQuidet
pushed a commit
to Mappy/mapbox-gl-native
that referenced
this pull request
Aug 6, 2018
…a paired icon/text Fixes issue #12483.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #12483.
Port of mapbox/mapbox-gl-js#7041.
I don't know a good way to write automated tests for this on the native side since we do our render tests in "still mode" which skips this logic. @RomainQuidet would you be interested in trying out this branch to see if it addresses your problem? (Also since it looks like you're also rendering the map with GL JS you could test against the GL JS PR)
/cc @ansis