This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[android] Keep CompassView's state up to date when compass is enabled. #15606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobrun
reviewed
Sep 11, 2019
tobrun
added
the
needs changelog
Sure, added unit tests for updating CompassView in UISettings. |
pengdev
force-pushed
the
peng-update-compassview-ui-settings
branch
from
47b7611 to
ea0ea31
Compare
pengdev
force-pushed
the
peng-update-compassview-ui-settings
branch
from
ea0ea31 to
cf64143
Compare
pengdev
removed
the
needs changelog
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #15133
Reproduced the above issue by setting
setCompassEnabled()to false initially and enable it after 5 seconds time out.As seen above, the compass view is not visible immediately after the
setCompassEnabledcall. Instead, only after user moved the map, the CompassView then showed up.This PR resolves the issue by passing through the camera position update to the mapView regardless of whether the compass is enabled, and update the MapView's rotation when the
MapView.setEnabled()is called.