This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if (self.zoomLevel < self.currentMinimumZoom) | ||
{ | ||
[self setZoomLevel:self.currentMinimumZoom animated:YES]; | ||
_userTrackingMode = MGLUserTrackingModeFollowWithHeading; // reapply |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea.
Happy to be rid of the old mock location stuff, was clunky. I'll kick the tires on this a bit now... |
Travis is failing on
And bitrise is failing on
|
Seeing
|
b7f5b39
to
2eac606
Compare
Yeah, still getting fails here, hardly ever locally, but flapping on Bitrise and Travis. Just rebased off of a243f41 to ditch Travis, though. |
4 tasks
b9b7b81
to
71ebef2
Compare
Current take here is to:
Refs #2213 |
This is passing Bitrise and the iOS slice is no longer on Travis, so will prep this for merge now. |
d2213f0
to
48d6d03
Compare
This was referenced Oct 27, 2015
Still getting this failure locally:
|
The failure is being tracked in #2920. |
friedbunny
added a commit
that referenced
this pull request
Jan 15, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MGLMapView
.Debug
since it runs faster these days.Going to squash/rebase/finalize etc. before merging.
/cc @friedbunny @1ec5