This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Set iOS application bundle as asset root #3087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1ec5
changed the title
|
👍 ++ |
As of #2746, we no longer bundle any styles with the SDK, so the asset: URL scheme is unused. Instead, point asset: to the application root for developer convenience and consistency with the Android and default asset roots. Also fixed an issue that prevented relative URLs from being treated as asset: URLs. Fixes #1208, fixes #3050.
1ec5
force-pushed
the
1ec5-asset-root-3050
branch
from
8ef923a to
b3dbdb3
Compare
|
Cherry-picked to release-ios-v3.0.0 in c4558d4. |
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of #2746, we no longer bundle any styles with the SDK, so the asset: URL scheme is unused. Instead of pointing asset: into Mapbox.bundle, point it to the application bundle for developer convenience and consistency with the Android and default asset roots. (asset: URLs also work this way for sprite URLs.) Also fixed an issue that prevented relative URLs from being treated as asset: URLs.
Fixes #1208, fixes #3050.
/cc @friedbunny @incanus