Move class handling to Style

[brunoabinader]

Fixes #6118.

• Map::Impl now owns class data.
• This prevents class state being reset upon mbgl::Style state changes.
• Adds new mbgl::setClassTransition to cleanup class API.
  • Updated GLFW and darwin API usage accordingly
• Update Qt QML: classes property now belongs to QQuickMapboxGL (map) instead of QQuickMapboxGLStyle (style)

[mention-bot]

@brunoabinader, thanks for your PR! By analyzing this pull request, we identified @jfirebaugh, @1ec5 and @incanus to be potential reviewers.

[brunoabinader]

Tagging @tmpsantos for reviewing the Qt changes 👍

[jfirebaugh]

@brunoabinader Sorry for the flip-flop, but after reviewing how style batch updates happen in GL JS and will need to happen in native for #5701, I think you had the right idea moving classes to Style, and we should stick with that (and change JS to match -- mapbox/mapbox-gl-js#2385). I'm prepping a PR for JS that demonstrates the benefit pretty clearly.

👍 on setClassTransition though, the existing transition argument behaves strangely (only most recent value is respected).

[tmpsantos]

Reviewed offline.

[brunoabinader]

@jfirebaugh rewrote the PR, keeping class handling in Style and applying the transition options changes. @tmpsantos we can forward the QML style property behavior changes to the upcoming QML style layer PR.

[jfirebaugh]

Can you just do EXPECT_EQ(map.getTransitionOptions().duration, duration) here? Ditto line 260.

[brunoabinader]

Yes and no - with the current implementation I get invalid operands to binary expression ('const std::experimental::fundamentals_v1::optional<std::__1::chrono::duration<long long, std::__1::ratio<1, 1000000000> > >' and 'const std::__1::chrono::duration<long long, std::__1::ratio<1, 1000> >') - but if I encapsulate duration inside mbgl::Duration then it works fine 👍 Thanks!

[jfirebaugh]

LGTM, modulo the nit in the test code and the CI failures.