This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[ios] Remove double counting of content inset top and bottom #6566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the calls to top and bottom for content inset of the map view when calculating the edge padding for following. A previous commit added this along with the left and right values. This eliminates a bug where the map did not scroll to the correct location for the user dot and also a bug in `didUpdateLocationWithUserTrackingAnimated:` where the map panning operations would always occur because the current and correct points never matched up even if a stream of location values that were the same were processed.
|
@boundsj, thanks for your PR! By analyzing the history of the files in this pull request, we identified @1ec5, @incanus and @friedbunny to be potential reviewers. |
1ec5
approved these changes
Oct 4, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the calls to top and bottom for content inset of the map view when calculating the edge padding for following. #6313 added this along with the left and right values.
The correction in this PR eliminates a bug where the map did not scroll to the correct location for the user dot (it was several points off on the y axis) and also a bug in
didUpdateLocationWithUserTrackingAnimated:where the map panning operations would always occur because the current and correct points never matched up even if a stream of location values that were the same were processed.cc @1ec5 @friedbunny