This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Fix SDK compilation in Xcode 7.3 #6923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Define NSErrorDomain before its first use. Define NSNotificationName as a typedef instead of a #define. Guard these shims on the existence of NS_STRING_ENUM rather than another macro that’s new to Xcode 8. Fixes #6906.
1ec5
added
iOS
|
@1ec5, thanks for your PR! By analyzing the history of the files in this pull request, we identified @friedbunny, @frederoni and @rmnblm to be potential reviewers. |
boundsj
approved these changes
Nov 4, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Define
NSErrorDomainbefore its first use. DefineNSNotificationNameas a typedef instead of a#define. Guard these shims on the existence ofNS_STRING_ENUMrather than another macro that’s new to Xcode 8.Fixes #6906.
/cc @boundsj