This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Cherry pick 7242 into iOS 3.4.0 release branch #7408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Style::relayout uses source.baseImpl->loaded, a flag which is updated by Style::recalculate. So recalculate first, then relayout.
|
@boundsj, thanks for your PR! By analyzing this pull request, we identified @jfirebaugh, @1ec5 and @incanus to be potential reviewers. |
jfirebaugh
approved these changes
Dec 13, 2016
boundsj
added
bug
iOS
|
Noting that this cherry picks:
but not:
from: #7242 I don't think 2d32321 is critical for iOS (Darwin) so we can just pick it up in the eventual merge back to master. cc @1ec5 @jfirebaugh fyi @ivovandongen |
FYI, I think that change would affect small map views in both iOS and macOS. (The calculation appears to depend on the viewport size, not the screen size.) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.