-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[android] Add support for data driven styling #7752
Conversation
@ivovandongen, thanks for your PR! By analyzing this pull request, we identified @incanus and @jfirebaugh to be potential reviewers. |
@mapbox/android I've restored support for exponential zoom functions on this branch and set up the basis for the property / zoom-and-property functions. For this I adhered to the naming in the style spec and not the core naming. So, for example, |
dc0a02c
to
8d08c61
Compare
After the discussion yesterday I've re-implemented the functions and stops with typed stops in 0a28d4d. Overall, I think it looks good. We now have: Functions:
Stops:
The DSL is spread out in
And like this for
The typing is a little uncomfortable when interrogating the style. Suggestions are welcome. |
8d08c61
to
0a28d4d
Compare
2e124af
to
db4a9ed
Compare
704bce3
to
9a8236c
Compare
API looks great, can't think of a simpler construction as the proposed DSL. |
I've implemented the composite functions (unit test generation forthcoming). The DSL for composite functions looks similar to the style spec format for Zoom-And-Property functions:
Where there is only one stops implementation for all zoom levels. An alternative which is closer to the representation in the core implementation and the proposal for function revision:
This offers more flexibility, but is also more verbose. The data representation follows the core and stores a In addition, I made some changes to the
|
213e6a5
to
43b6081
Compare
140d686
to
2b017e6
Compare
@jfirebaugh Finished up on this. After reviews, shall I merge it back into the |
4dda0fe
to
d867492
Compare
2b017e6
to
d5a6b8e
Compare
Adds support for data driven styling to the Android SDK.
TODO:
Functions
Other:
Property
andPropertyValue