This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[android] Fix my location drawable getting tinted #9410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Guardiola31337
force-pushed
the
pg-9393-my-loc-drawable-tinted
branch
2 times, most recently
from
023eeb2 to
7aa6f9a
Compare
|
The same should be done for |
|
Looking good, though I think @cammace request is valid for doing the same for background tint. |
tobrun
approved these changes
Jul 5, 2017
…or in xml issue (linking my location foreground drawables with my location foreground tint color and adding the possibility of setting an undefined my location foreground tint color)
… color and add the possibility of setting an undefined my location background tint color
Guardiola31337
force-pushed
the
pg-9393-my-loc-drawable-tinted
branch
from
bbf768f to
4c36782
Compare
tobrun
pushed a commit
that referenced
this pull request
Jul 20, 2017
* fix my location drawable tinted when setting mapbox_myLocationTintColor in xml issue (linking my location foreground drawables with my location foreground tint color and adding the possibility of setting an undefined my location foreground tint color) * link my location background drawable with my location background tint color and add the possibility of setting an undefined my location background tint color
tobrun
pushed a commit
that referenced
this pull request
Jul 21, 2017
* fix my location drawable tinted when setting mapbox_myLocationTintColor in xml issue (linking my location foreground drawables with my location foreground tint color and adding the possibility of setting an undefined my location foreground tint color) * link my location background drawable with my location background tint color and add the possibility of setting an undefined my location background tint color
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👀 @tobrun @cammace