This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[core] Remove database on schema downgrade #9817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we were throwing an exception.
Which is, delete and recreate the database.
|
@jfirebaugh this was brought up by a Qt user. I think it sane, since there might be a case where you deploy an app with a certain version of mbgl and have to revert for some reason. |
|
Fixes #9776, see discussion there. This seems like a reasonable solution. |
jfirebaugh
approved these changes
Aug 21, 2017
|
Awesome — looking forward to cherry-picking this into |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we were throwing an exception.