Move to constants, make a public #1124
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| import Foundation | ||
|
|
||
| extension Dictionary where Key == Int, Value: MGLStyleValue<NSNumber> { | ||
| /** | ||
| Returns a copy of the stop dictionary with each value multiplied by the given factor. | ||
| */ | ||
| public func multiplied(by factor: Double) -> Dictionary { | ||
| var newCameraStop: [Int: MGLStyleValue<NSNumber>] = [:] | ||
| for stop in MBRouteLineWidthByZoomLevel { | ||
| let f = stop.value as! MGLConstantStyleValue | ||
| let newValue = f.rawValue.doubleValue * factor | ||
| newCameraStop[stop.key] = MGLStyleValue<NSNumber>(rawValue: NSNumber(value:newValue)) | ||
| } | ||
| return newCameraStop as! Dictionary<Key, Value> | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,30 @@ | ||
| import Foundation | ||
| import MapboxDirections | ||
|
|
||
| typealias CongestionSegment = ([CLLocationCoordinate2D], CongestionLevel) | ||
|
|
||
| /** | ||
| Line width base values used at zoom levels. | ||
|
There was a problem hiding this comment.
|
||
| */ | ||
| public let MBRouteLineWidthByZoomLevel: [Int: MGLStyleValue<NSNumber>] = [ | ||
| 10: MGLStyleValue(rawValue: 8), | ||
| 13: MGLStyleValue(rawValue: 9), | ||
| 16: MGLStyleValue(rawValue: 11), | ||
| 19: MGLStyleValue(rawValue: 22), | ||
| 22: MGLStyleValue(rawValue: 28) | ||
| ] | ||
|
|
||
| /** | ||
| The minium distance remaining on a route before overhead zooming is stopped. | ||
| */ | ||
| public var NavigationMapViewMinimumDistanceForOverheadZooming: CLLocationDistance = 200 | ||
|
|
||
| /** | ||
| Attribute name for the route line that is used for identifying whether a RouteLeg is the current active leg. | ||
| */ | ||
| public let MBCurrentLegAttribute = "isCurrentLeg" | ||
|
|
||
| /** | ||
| Attribute name for the route line that is used for identifying different `CongestionLevel` along the route. | ||
| */ | ||
| public let MBCongestionAttribute = "congestion" | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| import Foundation | ||
|
|
||
| extension Dictionary where Key == Int, Value: MGLStyleValue<NSNumber> { | ||
| /** | ||
| Returns a proportional `Dictionary` of `lineWidthAtZoomLevels` at a specific factor. | ||
|
There was a problem hiding this comment. As written, this method could just as well operate on circle size stops, not just line width stops:
|
||
| */ | ||
| public func multiplied(by factor: Double) -> Dictionary { | ||
|
There was a problem hiding this comment. This method will also go away as part of the migration to expressions in #1076. |
||
| var newCameraStop: [Int: MGLStyleValue<NSNumber>] = [:] | ||
| for stop in lineWidthAtZoomLevels { | ||
| let f = stop.value as! MGLConstantStyleValue | ||
| let newValue = f.rawValue.doubleValue * factor | ||
| newCameraStop[stop.key] = MGLStyleValue<NSNumber>(rawValue: NSNumber(value:newValue)) | ||
| } | ||
| return newCameraStop as! Dictionary<Key, Value> | ||
| } | ||
| } | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because this line refers to
MBRouteLineWidthByZoomLevelinstead ofself, this code:magically produces a dictionary equivalent to
MBRouteLineWidthByZoomLevel, even thoughMBRouteLineWidthByZoomLevelwas never used explicitly.