Marker Cluster Plugin #49

tobrun · 2017-06-21T12:25:58Z

This PR ports 2 open-source clustering algorithms from googlemaps/android-maps-utils.

Non-hierarchical distance based algorithm
Grid based algorithm

cc @mapbox/android

zugaldia

Just small notes. I realize there're a bunch of TODO and UNSUPPORTED that probably come from the original library. I'd check which ones are worth ticketing. Otherwise, let's at least add a note saying something like "This TODO item was part of the original library (http://...), we welcome contributions if you want to work on it. See https://github.com/mapbox/mapbox-plugins-android#contributing for details."

zugaldia · 2017-06-23T13:40:01Z

plugins/cluster/build.gradle

+    compile('com.mapbox.mapboxsdk:mapbox-android-sdk:5.1.0-beta.3@aar') {
+        transitive = true
+    }
+//    javadocDeps 'com.mapbox.mapboxsdk:mapbox-android-sdk:5.0.2'


Was this left commented on purpose? Should we remove it instead?

This setup was copied from the traffic plugin and will be required for release. Since there is a need for a final 5.1.0 of the map SDK (dependency on new OnCameraIdle API). I would leave this untouched until the release of this plugin.

zugaldia · 2017-06-23T13:40:35Z

plugins/cluster/src/main/AndroidManifest.xml

+          package="com.mapbox.mapboxsdk.plugins.cluster"
+>
+
+    <application android:allowBackup="true"


I believe we can remove the application tag from here.

zugaldia · 2017-06-23T13:40:52Z

plugins/cluster/src/main/java/com/mapbox/mapboxsdk/plugins/cluster/MarkerManager.java

+import java.util.Map;
+import java.util.Set;
+
+// TODO: add OnMarkerDragListener


mapbox/mapbox-gl-native#2450

zugaldia · 2017-06-23T13:41:05Z

.../mapbox/mapboxsdk/plugins/cluster/clustering/algo/NonHierarchicalDistanceBasedAlgorithm.java

+  }
+
+  private Bounds createBoundsFromSpan(Point p, double span) {
+    // TODO: Use a span that takes into account the visual size of the marker, not just its


This is a todo from the original implementation

zugaldia · 2017-06-23T13:41:17Z

.../java/com/mapbox/mapboxsdk/plugins/cluster/clustering/algo/PreCachingAlgorithmDecorator.java

+
+  private final Algorithm<T> algorithm;
+
+  // TODO: evaluate maxSize parameter for LruCache.


this is a todo from the original implementation

zugaldia · 2017-06-23T13:45:42Z

plugins/cluster/src/test/java/com/mapbox/mapboxsdk/plugins/cluster/ExampleUnitTest.java

+ *
+ * @see <a href="http://d.android.com/tools/testing">Testing documentation</a>
+ */
+public class ExampleUnitTest {


Looks like we can remove this file.

zugaldia · 2017-06-23T13:46:21Z

...c/main/java/com/mapbox/mapboxsdk/plugins/cluster/clustering/view/DefaultClusterRenderer.java

+
+      final Set<MarkerWithPosition> markersToRemove = markers;
+      final LatLngBounds visibleBounds = mProjection.getVisibleRegion().latLngBounds;
+      // TODO: Add some padding, so that markers can animate in from off-screen.


this is a todo from the original implementation

zugaldia · 2017-06-23T13:46:29Z

...c/main/java/com/mapbox/mapboxsdk/plugins/cluster/clustering/view/DefaultClusterRenderer.java

+      for (final MarkerWithPosition marker : markersToRemove) {
+        boolean onScreen = visibleBounds.contains(marker.position);
+        // Don't animate when zooming out more than 3 zoom levels.
+        // TODO: drop animation based on speed of device & number of markers to animate.


this is a todo from the original implementation

zugaldia · 2017-06-23T13:46:37Z

...c/main/java/com/mapbox/mapboxsdk/plugins/cluster/clustering/view/DefaultClusterRenderer.java

+      return null;
+    }
+
+    // TODO: make this configurable.


this is a todo from the original implementation

zugaldia · 2017-06-23T13:46:50Z

...c/main/java/com/mapbox/mapboxsdk/plugins/cluster/clustering/view/DefaultClusterRenderer.java

+  private static final TimeInterpolator ANIMATION_INTERP = new DecelerateInterpolator();
+
+  /**
+   * Animates a markerWithPosition from one position to another. TODO: improve performance for


this is a todo from the original implementation

tobrun · 2017-08-01T12:25:17Z

@zugaldia I was able to make the code work with a configurable flag for MarkerView though the performance wasn't great. I'm thinking on punting on Markers as we aim to deprecate MarkerView in upcoming releases in mapbox/mapbox-gl-native#9365.

mdakram · 2017-08-01T16:45:29Z

Small issue with this plugin is there is no option to disable clustering at certain zoom level, say we need to plot 5 markers in 5 mtrs radius even at last zoom level we are not able to see all markers.

Is there any workaround for this?

zugaldia · 2017-08-17T15:34:39Z

I'm thinking on punting on Markers as we aim to deprecate MarkerView in upcoming releases in mapbox/mapbox-gl-native#9365.

👍 on reducing the scope to markers for now.

simon1867 · 2017-10-19T16:59:01Z

Is there a timeframe on getting this PR merged? I'm currently in the process of migrating from Google Maps and this is one of the main features missing on MapBox for my usage.

tobrun · 2017-10-20T16:23:33Z

@simon-the-canadian I'm working on rebasing this PR on latest changes of master.
Will merge once CI has approved.

cc @lilykaiser

simon1867 · 2017-10-27T21:42:11Z

@tobrun Are you guys planning on releasing an artifact to maven soonish?

maheshchakkarwar1 · 2024-07-28T12:27:03Z

When I run this code. Not working for me.
org.maplibre.android.exceptions.CalledFromWorkerThreadException: Map interactions should happen on the UI thread. Method invoked from wrong thread is latLngForPixel. at org.maplibre.android.maps.NativeMapView.checkState(NativeMapView.java:119) at org.maplibre.android.maps.NativeMapView.latLngForPixel(NativeMapView.java:713) at org.maplibre.android.maps.Projection.fromScreenLocation(Projection.java:96) at org.maplibre.android.maps.Projection.getVisibleRegion(Projection.java:153) at org.maplibre.android.maps.Projection.getVisibleRegion(Projection.java:122) at commichelin.clustering.view.DefaultClusterRenderer$RenderTask.run(DefaultCl

tobrun self-assigned this Jun 21, 2017

tobrun requested a review from zugaldia June 21, 2017 12:25

tobrun mentioned this pull request Jun 22, 2017

Point annotation clustering mapbox/mapbox-gl-native#5814

Open

zugaldia reviewed Jun 23, 2017

View reviewed changes

tobrun mentioned this pull request Jul 14, 2017

Create new GeoJsonSource takes long time (6-11 seconds) from FeatureCollection of 20000 items. mapbox/mapbox-gl-native#9513

Closed

tobrun force-pushed the tvn-clustering branch from 1802ae3 to cb99edf Compare August 1, 2017 14:25

tobrun force-pushed the tvn-clustering branch from cb99edf to 7951647 Compare August 3, 2017 05:48

tobrun force-pushed the tvn-clustering branch 7 times, most recently from a06a718 to 6bcfc42 Compare August 23, 2017 14:33

zugaldia approved these changes Aug 23, 2017

View reviewed changes

Add cluster plugin

167d01c

tobrun force-pushed the tvn-clustering branch from cace667 to 167d01c Compare October 20, 2017 15:39

tobrun merged commit f0d6e4a into master Oct 21, 2017

tobrun deleted the tvn-clustering branch October 21, 2017 08:52

jmkiley mentioned this pull request Oct 24, 2017

Clustering plugin mapbox/mapbox-plugins-ios#6

Open

This was referenced Feb 21, 2018

Map unable to display on activity mapbox/mapbox-gl-native#10157

Closed

Map gets displayed but the markers aren't loaded and there's an error mapbox/mapbox-gl-native#11269

Closed

MArman88 mentioned this pull request Sep 10, 2018

Fatal signal 11 (SIGSEGV), code 1 #265

Closed

DavisDevasia mentioned this pull request Jun 30, 2021

Crash When Clustering Pins on MapBox 6.2.0 #563

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Marker Cluster Plugin #49

Marker Cluster Plugin #49

tobrun commented Jun 21, 2017

zugaldia left a comment

zugaldia Jun 23, 2017

tobrun Jun 23, 2017

zugaldia Jun 23, 2017

tobrun Jun 23, 2017

zugaldia Jun 23, 2017

tobrun Jun 23, 2017

zugaldia Jun 23, 2017

tobrun Jun 23, 2017

zugaldia Jun 23, 2017

tobrun Jun 23, 2017

zugaldia Jun 23, 2017

zugaldia Jun 23, 2017

tobrun Jun 23, 2017

zugaldia Jun 23, 2017

tobrun Jun 23, 2017

zugaldia Jun 23, 2017

tobrun Jun 23, 2017

zugaldia Jun 23, 2017

tobrun Jun 23, 2017

tobrun commented Aug 1, 2017

mdakram commented Aug 1, 2017

zugaldia commented Aug 17, 2017

simon1867 commented Oct 19, 2017

tobrun commented Oct 20, 2017

simon1867 commented Oct 27, 2017

maheshchakkarwar1 commented Jul 28, 2024


		private final Algorithm<T> algorithm;

		// TODO: evaluate maxSize parameter for LruCache.

Marker Cluster Plugin #49

Marker Cluster Plugin #49

Conversation

tobrun commented Jun 21, 2017

zugaldia left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tobrun commented Aug 1, 2017

mdakram commented Aug 1, 2017

zugaldia commented Aug 17, 2017

simon1867 commented Oct 19, 2017

tobrun commented Oct 20, 2017

simon1867 commented Oct 27, 2017

maheshchakkarwar1 commented Jul 28, 2024