Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boost 1.67.0 #599

Merged
merged 2 commits into from
Dec 3, 2018
Merged

Boost 1.67.0 #599

merged 2 commits into from
Dec 3, 2018

Conversation

springmeyer
Copy link
Contributor

@springmeyer springmeyer commented Apr 22, 2018

Created with:

git checkout -b boost-1.67.0
./utils/new_boost.sh create 1.67.0 1.66.0
git add scripts/boost*/1.67.0/
git commit -a -m "boost 1.67.0"
./utils/new_boost.sh trigger 1.67.0

Then I noticed the boost_python builds failed. Debugging locally I found that the library name changed. Fixed this in bb564ee and then manually triggered a build for just boost_python in: https://travis-ci.org/mapbox/mason/builds/369861321 with ./mason trigger boost_libpython 1.67.0

@springmeyer
Copy link
Contributor Author

@AllieOop - assigned you as a reviewer here. Let's go over this together to check my work / confirm the fix works before merging.

@sssoleileraaa
Copy link
Contributor

My PR walk-through with @springmeyer helped make sense of the changes he made. The first commit shows the fix he made and that's what we spent time discussing. The second commit is the automated/boilerplate code.

After I run through a manual test of boost_libpython like we discussed, I think we should be good to merge this!

@springmeyer springmeyer merged commit f4d3e10 into master Dec 3, 2018
@springmeyer springmeyer deleted the boost-1.67.0 branch December 3, 2018 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants