Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a check to ensure that the directory does not already exist in the project directory #1127

Conversation

YevhenZvieriev
Copy link
Contributor

@YevhenZvieriev YevhenZvieriev commented Apr 17, 2024

This pull request modifies the bin/download script to include a check for the existence of the 'bin' directory both in the project directory before continuing with the installation process. If the 'bin' directory is found, the script will terminate with an error message, prompting the user to resolve the issue before proceeding.

This enhancement improves the reliability of the installation process by preemptively detecting and handling potential conflicts. It ensures a smoother experience for users and reduces the likelihood of installation failures due to directory conflicts.

Screenshot from 2024-04-17 22-13-03

Screenshot from 2024-04-17 23-04-42

Fixes #1126

@markshust
Copy link
Owner

Thanks! I just updated the verbiage so it's not specific to the bin directory, as the directory could be full of random files and folders. Appreciate it!

@markshust markshust merged commit ed401d3 into markshust:release/next Apr 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Abort docker-compose install on non-empty directory
2 participants