Merge pull request #3736 from marmelab/fix-boolean-input

[RFR] Fix BooleanInput Does Not Update on Label Click

packages/ra-ui-materialui/src/input/BooleanInput.spec.tsx

@@ -1,5 +1,10 @@
 import React from 'react';
-import { render, cleanup, fireEvent } from '@testing-library/react';
+import {
+    render,
+    cleanup,
+    fireEvent,
+    waitForDomChange,
+} from '@testing-library/react';
 import { Form } from 'react-final-form';
 
 import BooleanInput from './BooleanInput';
@@ -74,6 +79,22 @@ describe('<BooleanInput />', () => {
         expect(input.checked).toBe(false);
     });
 
+    it('should update on click', async () => {
+        const { getByLabelText } = render(
+            <Form
+                onSubmit={jest.fn}
+                render={() => <BooleanInput {...defaultProps} />}
+            />
+        );
+
+        const input = getByLabelText(
+            'resources.posts.fields.isPublished'
+        ) as HTMLInputElement;
+
+        fireEvent.click(input);
+        expect(input.checked).toBe(true);
+    });
+
     it('should displays errors', () => {
         // This validator always returns an error
         const validate = () => 'ra.validation.error';

packages/ra-ui-materialui/src/input/BooleanInput.tsx

@@ -52,7 +52,6 @@ const BooleanInput: FunctionComponent<
     return (
         <FormGroup {...sanitizeRestProps(rest)}>
             <FormControlLabel
-                htmlFor={id}
                 control={
                     <Switch
                         id={id}