Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Support] <SaveContextProvider> deprecated-message of React-Admin #5563

Closed
tanpld opened this issue Nov 20, 2020 · 4 comments · Fixed by #5597
Closed

[Support] <SaveContextProvider> deprecated-message of React-Admin #5563

tanpld opened this issue Nov 20, 2020 · 4 comments · Fixed by #5597
Assignees
@fzaninotto
Labels
bug

Comments

@tanpld
Copy link

tanpld commented Nov 20, 2020

I have this message in the Chrome console since I updated react-admin to version 3.10.0, I tried to dig into the document but can't find any information or example. Anyone encounter this, or luckily any members of react-admin seeing this, please help!

Edit or Create child components must be used inside a <SaveContextProvider>. Relying on props rather than context to get persistence related data and callbacks is deprecated and won't be supported in the next major version of react-admin.
@djhi
Copy link
Collaborator

djhi commented Nov 20, 2020

Are you using custom Create or Edit components ?

@kaluohena
Copy link

I am using the custom Edit component and get the same warning.

@tanpld
Copy link
Author

tanpld commented Nov 26, 2020

Are you using custom Create or Edit components ?

Yes, custom one

@djhi
Copy link
Collaborator

djhi commented Nov 27, 2020

Reproduced. Thanks

@djhi djhi added bug and removed needs more info labels Nov 27, 2020
@fzaninotto fzaninotto self-assigned this Nov 27, 2020
fzaninotto added a commit that referenced this issue Nov 27, 2020
@fzaninotto
[Doc] Fix create and edit controller usage documentation
e1ad7e6 
closes #5563
@fzaninotto fzaninotto mentioned this issue Nov 27, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fzaninotto fzaninotto

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Doc] Fix create and edit controller usage documentation marmelab/react-admin
4 participants
@fzaninotto @djhi @kaluohena @tanpld