Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFR] Replace injected elements by injected components #3262

Merged
merged 21 commits into from
May 23, 2019
Merged

[RFR] Replace injected elements by injected components #3262

merged 21 commits into from
May 23, 2019

Conversation

djhi
Copy link
Collaborator

@djhi djhi commented May 22, 2019 •
edited
Loading

  • auth
  • buttons
  • detail
  • fields
  • form
  • inputs
  • layout
  • list
  • Upgrade instructions

Fixes #3246

@djhi djhi added this to the 3.0.0 milestone May 22, 2019
@fzaninotto
Copy link
Member

Don't forget the UPGRADE instructions!

djhi added 14 commits May 22, 2019 12:15
@djhi
Migrate layout components to require components instead of elements
e1f7e41
@djhi
Login: use children instead of a custom prop
295e922
@djhi
Buttons: use JSX instead of createElement
cb5ce09
@djhi
Detail components: use JSX instead of createElement
eaeb238
@djhi
Layout components: use JSX instead of createElement
1eb64cd
@djhi
Migrate list components to require components instead of elements
db1fe50
@djhi
Fix simple example
943ca0d
@djhi
Fix unit tests
4a8652b
@djhi
Speed up & stabilize e2e tests by blocking unsplash host in cypress
8d5c5b7
@djhi
Migrate form components to require components instead of elements
d9e5fc9
@djhi
Migrate field components to require components instead of elements
70c1b9a
@djhi
Migrate input components to require components instead of elements
1c20130
@djhi
Update documentation & missing components
3b58102
@djhi
Update documentation
c02ca55
@fzaninotto fzaninotto mentioned this pull request May 22, 2019
Closed
40 tasks
fzaninotto
fzaninotto approved these changes May 22, 2019
View reviewed changes
Copy link
Member

@fzaninotto fzaninotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks for the hard work.

Overall, the code is clearer like that. Don't forget to mention the deletion of the deprecated components and the optionText prop in the Upgrade guide.

@djhi djhi changed the title [WIP] Replace injected elements by injected components [RFR] Replace injected elements by injected components May 22, 2019
@fzaninotto fzaninotto merged commit 05699c4 into next May 23, 2019
@fzaninotto fzaninotto deleted the replace_injected_elements_by_injected_components branch May 23, 2019 14:21
@fzaninotto
Copy link
Member

Awesome!

@fzaninotto fzaninotto mentioned this pull request May 23, 2019
Closed
@fzaninotto fzaninotto mentioned this pull request May 27, 2019
Closed
@djhi djhi mentioned this pull request Jun 5, 2019
Merged
@fzaninotto fzaninotto removed this from the 3.0.0 milestone Jun 6, 2019
@djhi djhi mentioned this pull request Jun 6, 2019
Merged
@fzaninotto fzaninotto added this to the 3.0.0 milestone Jun 6, 2019
@smeng9 smeng9 mentioned this pull request Jun 20, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fzaninotto fzaninotto fzaninotto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@djhi @fzaninotto