Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFR] Remove useless sagas #3693

Merged
merged 3 commits into from
Sep 15, 2019
Merged

[RFR] Remove useless sagas #3693

merged 3 commits into from
Sep 15, 2019

Conversation

fzaninotto
Copy link
Member

  • Remove error saga (already covered by validateResponseFormat)
  • Move unload saga logic to useDataProvider hook. That means there will no longer be unload warnings for optimistic fetch actions, but it's impossible to keep the two handlers

@djhi djhi added this to the 3.0.0 milestone Sep 15, 2019
Copy link
Collaborator

@djhi djhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@djhi djhi merged commit 74ea70d into next Sep 15, 2019
@djhi djhi deleted the saga-cleanup branch September 15, 2019 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants