[RFR] Introduce useGetMatching and useReferenceArrayInputController #3698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
djhi
commented
Sep 16, 2019
•
djhi
commented
- useGetMatching
- useReferenceArrayInputController
- Fix tests
djhi
force-pushed
the
use-get-matching
branch
from
3db9430 to
f84e6cb
Compare
fzaninotto
requested changes
Sep 17, 2019
packages/ra-core/src/controller/input/ReferenceArrayInputController.spec.tsx
Outdated
Show resolved
Hide resolved
packages/ra-core/src/controller/input/ReferenceArrayInputController.spec.tsx
Show resolved
Hide resolved
packages/ra-core/src/controller/input/ReferenceArrayInputController.spec.tsx
Outdated
Show resolved
Hide resolved
| const useReferenceArrayInputController = ({ | ||
| basePath, | ||
| filter: defaultFilter, | ||
| filterToQuery = searchText => ({ q: searchText }), |
There was a problem hiding this comment.
Move the default value to a constant to avoid having a new function at every render, defeating your useMemo line 93
packages/ra-core/src/controller/input/useReferenceArrayInputController.ts
Show resolved
Hide resolved
| options | ||
| ); | ||
|
|
||
| const finalReferenceRecords = referenceRecords.filter( |
There was a problem hiding this comment.
We need a comment here, like "filter out not found references - happens when the dataProvider doesn't guarantee referential integrity"
|
|
||
| const dataStatus = getDataStatus({ | ||
| input, | ||
| // We merge the currently selected records with the matching ones, otherwise |
There was a problem hiding this comment.
I think you should move this comment up to line 115
| const referenceSource = (resource, source) => `${resource}@${source}`; | ||
|
|
||
| /** | ||
| * Call the dataProvider with a GET_LIST verb and return the result as well as the loading state. |
There was a problem hiding this comment.
The comment is the same as useGetList... You should tweak it so that readers understand the difference
There was a problem hiding this comment.
It is tweaked in the example. GET_MATCHING is actually sent as GET_LIST
| * | ||
| * import { useGetMatching } from 'react-admin'; | ||
| * | ||
| * const LatestNews = () => { |
djhi
commented
Sep 17, 2019
packages/ra-core/src/controller/input/ReferenceArrayInputController.spec.tsx
Show resolved
Hide resolved
djhi
commented
Sep 17, 2019
packages/ra-core/src/controller/input/ReferenceArrayInputController.spec.tsx
Show resolved
Hide resolved
djhi
changed the title
fzaninotto
approved these changes
Sep 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.