Update dependencies #4872
Merged
Update dependencies #4872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm -1 about changing the version in peerDependencies. We don't need it, and it can be considered as a breaking change. We need to check the package is forward compatible, not break its backward compatibility. |
fzaninotto
requested changes
May 28, 2020
packages/react-admin/package.json
Outdated
| "@material-ui/core": "^4.3.3", | ||
| "@material-ui/icons": "^4.2.1", | ||
| "@material-ui/styles": "^4.3.3", | ||
| "@material-ui/core": "^4.10.0", |
There was a problem hiding this comment.
the dependencies in react-admin should not change either.
fzaninotto
reviewed
May 29, 2020
| version "7.8.4" | ||
| resolved "https://registry.yarnpkg.com/@babel/runtime/-/runtime-7.8.4.tgz#d79f5a2040f7caa24d53e563aad49cbc05581308" | ||
| integrity sha512-neAp3zt80trRVBI1x0azq6c57aNBqYZH8KhMm3TaB7wEI5Q4A2SHfBHE8w9gOhI/lrqxtEbXZgQIrHP+wvSGwQ== | ||
| dependencies: | ||
| regenerator-runtime "^0.13.2" | ||
|
|
||
| "@babel/runtime@^7.10.0": |
There was a problem hiding this comment.
This one is troublesome. Can you check that we don't double the runtime in production bundles?
There was a problem hiding this comment.
After building the demo, I can confirm the runtime isn't bundled twice
There was a problem hiding this comment.
In fact, the final bundle is even smaller (-2.45 KB) 😄
fzaninotto
approved these changes
May 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.