Fix flicker #200
Merged
Fix flicker #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These apply in full screen mode ONLY: i.e ALT-F2, Shredos etc. 1. When selecting a drive using up/down arrow keys 2. During a wipe the screen flashes at one second intervals. These apply in a terminal window such as konsole, tmux etc. 1. When resizing the terminal there was a flicker. All these problems have been fixed. Most of the causes of the flicker was an excessive use of wrefresh() which calls the wnoutrefresh() and doupdate() functions. This can cause flickering when a number of calls to wrefresh happen at the same time. It is more appropriate to replace the wrefresh() with wnoutrefresh(), then at an appropriate time call doupate() just once. The result is that before doupdate() would have been called multiple times and now it's called once when required. fixes martijnvanbrummelen#115
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes screen flicker seen in the following situations:
These apply in full screen mode ONLY: i.e ALT-F2, Shredos etc.
These apply in a terminal window such as konsole, tmux etc.
All these problems have been fixed.
Most of the causes of the flicker was an excessive use of wrefresh() which calls
the wnoutrefresh() and doupdate() functions. This can cause flickering when a
number of calls to wrefresh happen at the same time. It is more appropriate to
replace the wrefresh() with wnoutrefresh(), then at an appropriate time call
doupate() just once. The result is that before doupdate() would have been
called multiple times and now it's called once when required.
fixes #115