Add drive temperature monitoring #360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stage 1 adds the additional variables to the drive context and creates the temperature initialisation function, which associates a hwmonX directory with a block device. Also wrote the context update function, that reads hwmon for each drive context and writes the temperatures back to the context. Stage 2 commit to follow which will make changes within the GUI to call the update function every 60 seconds and display the temperature information.
Stage 2 modifies the GUI to trigger a temperature update every 60 seconds. Changes were made to the drive progress line to include [ 30C ]. The drive context structure had another variable added that records the time of the temperature update. Note. When the temperature data cannot be retrieved from the hwmon (drivetemp) module the GUI displays [ --C ]. USB devices, even those adapters that support ATA pass through, don't seem to work with hwmon (drivetemp), at least the adapters I have don't work with drivetemp to monitor temperature.
1. Changed u64 to int to support negative temperature values, i.e. temp1_lcrit may be as low as -40C 2. In gui surround temperature reading with square brackets instead of round brackets to be consistent with the rest of the drive status line
1. Changed gui format specifier to match signed integer that we changed to in the previous commit. 2. Changed the format specifier in verbose nwipe logging of the temperatures and moved the nwipe log message that prints the hwmonX path to the log in order to remove unnecessary printing to the log.
1. Changed a few nwipe log messages to improve readability. 2. Added code so that the temperature changes from - white text = (Temperature within spec) - red text = max continuous temp reached - red flashing text = critical upper temperature reached - black text = minimum continuous temperature reached - black flashing text = critical lower temperature reached.
This was referenced Nov 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Demo video showing how temperature display changes based on min,max,upper/lower critical limits as supplied by the drive.
nwipe_demo_temperature-2021-11-10_22.47.24.mp4