Anonymize SMBIOS/DMI data if -q --quiet specified #367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PartialVolume
deleted the
Anonymize_SMBIOS-DMI_data_in_log_when_q_option_used
branch
This was referenced Nov 15, 2021
Closed
|
Here's the SMBIOS/DMI test log using nwipe -v -q I also removed the LU WWN Device Id as it's a unique identifier. Should probably be also removed when using -q but I understand if this is too much work and of little use except for privacy-aware folks. Else the -q parameter seems to work as intended. Good job. Hats off. Thanks so much. |
|
I started a wipe on two drives |
|
Well I'm just seeing that smartmontools also removes the LU WWN ID when using -q so my request is not that outerworldy :)
source: https://www.smartmontools.org/wiki/FAQ#MyATASATAdriveisnotinthesmartctlsmartddatabase |
That's been like that for a while, nothing to do with the recent changes. It only occurs when you Control-C and is to do with how the -1 return status is issued by the wipe threads and how errors are handled. Basically it's a benign error that should report UABORTED when Control-C triggers an abort unless there has been an actual pass/verification or Fdatasync I/O error, then it should say FAILED. A fix for that is scheduled for today. So if possible you may want to keep that setup available for retesting. I'll update the 'LU WWN ID ' today as well. Thanks for taking the time to test this, it's really appreciated having another set of eyes on this. |
Will do. No problem.
You're the man. Thanks. |
I just re-tested this with the latest build. The UABORTED issue seems to be gone (I restest this later on the original device where this was happening). And the SMBIOS/DMI data is anonymized. I think this ticket can be closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Anonymize SMBIOS/DMI data if -q --quiet specified by the user.