Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rain map not working #253

Closed
carminemassarelli opened this issue Nov 15, 2017 · 5 comments
Closed

rain map not working #253

carminemassarelli opened this issue Nov 15, 2017 · 5 comments

Comments

@carminemassarelli
Copy link
Contributor

I use my api key but the rain map is not working.
I have forecastie 1.5 on lineageOS 14.1.
Is it a issue of the android version?
many thanks

@FridoDeluxe
Copy link
Contributor

FridoDeluxe commented Nov 16, 2017

I can confirm this behavior. When trying to download the image tiles for the rain map I received HTTP response code 500, while temperature and wind were still working. Comparing the code of map.html the with OWM's Weather map API there are differences in the URLs.

I tested just the HTML page with a new URL and included the appid:

// Rain
var rainLayer = new L.TileLayer("http://tile.openweathermap.org/map/precipitation_new/{z}/{x}/{y}.png?appid=" + getUrlParameter("appid"), {

This works for me. Hope this helps someone to replace all URLs and test if it also works inside the Android WebView (I can't do that at the moment).

@carminemassarelli
Copy link
Contributor Author

carminemassarelli commented Nov 18, 2017

I think it is not working this server link
http://{s}.maps.owm.io:8099/57b58d2a946d8a0100852aef/{z}/{x}/{y}?hash=d454ac88526eca77574f7d9c24a50efa
and this is a problem in the openweathermap editor server.
A way to fix this is to modify previous link with
http://tile.openweathermap.org/map/precipitation_new/{z}/{x}/{y}.png?appid="+getUrlParameter('appid')
but you have to create your appid before.
I do not know if martykan prefers this way to fix, but this works on my cloned project (as FridoDeluxe said).

@robinpaulson
Copy link
Contributor

@carminemassarelli @FridoDeluxe
Cheers for working on this; would one of you be able to put together a pull request?

If not, is it as simple as replacing the lines as detailed in the comment above?

carminemassarelli added a commit to carminemassarelli/forecastie that referenced this issue Dec 28, 2017
As suggested from @robinpaulson this is a pull request from a fork for the issue martykan#253 rain map not working.
If this is accepted the user need, before to see rain map, to create and then set in the form the own openweathermap apikey from here https://home.openweathermap.org/users/sign_up.
@carminemassarelli
Copy link
Contributor Author

carminemassarelli commented Dec 28, 2017

@robinpaulson @FridoDeluxe
I created a pull request in a fork because of I have not permission to write in the master.

@robinpaulson
Copy link
Contributor

@carminemassarelli
Marvellous. v1.6 will be out in a few days. As this patch is to fix broken functionality, I'll release v1.6.1 soon after, once we can see how v1.6 is going.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants