This repository has been archived by the owner on Jan 14, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 230
feat(menu): add component #786
Merged
moog16
merged 38 commits into
feat/mdcweb-typescript-update
from
feat/menu/addcomponent_try3
Apr 26, 2019
Merged
Changes from 1 commit
Commits
Show all changes
38 commits
Select commit
Hold shift + click to select a range
cae6b6d
WIP: menu
e237d30
WIP: Menu
f6cadef
fix: menu with seenshot
14a1183
WIP: selection menu
e80d458
WIP: menu
8d0b52a
WIP: getting menulistitem to be interpretted as a listitem
cb1694b
fix: menu list handleActionitem
aafb2d1
fix: add readme
4900f4d
feat: add tests
3abb5f4
fix: lint and test
61b076b
fix: add golden
05c48dd
fix: Pr changes
8a2196f
Merge branch 'feat/mdcweb-typescript-update' into feat/menu/addcompon…
6ee5ad7
WIP: using context to pass list item
85c0b93
Merge branch 'feat/mdcweb-typescript-update' into feat/menu/addcompon…
93bf167
Merge branch 'feat/menu/addcomponent_try3' into experiemental/menu/co…
c605cef
fix: using context instead
bb4c79b
fix: context is working
06e2ba6
fix: remove context from state
8ff2d9f
WIP: tests
667ed80
fix: tests
f2c0805
Merge branch 'feat/mdcweb-typescript-update' into feat/menu/addcompon…
9ded538
Merge branch 'experiemental/menu/context' into feat/menu/addcomponent…
7521f67
fix: commented tests
b10563c
fix: drawer test
395520d
Merge branch 'feat/mdcweb-typescript-update' into feat/menu/addcompon…
1b9b7a1
fix: memoize listProps
8ac8668
fix: revert esmoduleinterop
a5fe91e
Update index.tsx
cb75d24
fix: esmoduleinterop
949fd9e
fix: remove * as
e70dee4
fix: screenshots
3a8a01e
fix: move memoizeone
c6930a4
Merge branch 'feat/mdcweb-typescript-update' into feat/menu/addcompon…
ed4054f
fix: packagelock
d074619
fix: remove menu/index.scss
9c50842
fix: add a postinstall to fix react adapter
f93bcdf
fix: add -f so postinstall doesn't fail
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
import * as Enzyme from 'enzyme'; | ||
import * as Adapter from 'enzyme-adapter-react-16'; | ||
import Enzyme from 'enzyme'; | ||
import Adapter from 'enzyme-adapter-react-16'; | ||
Enzyme.configure({adapter: new Adapter()}); | ||
const context = require.context('.', true, /\.test\.(j|t)sx?$/); | ||
context.keys().forEach(context); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe you should place the call to
memoizeOne
directly here. If it's in render, the cache will still be reseted.(sorry for commenting so much 😅)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think my last comment wasn't clear enough, sorry
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe you're right again sir!
(please keep the comments coming)