Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for the colortbl package, and update its code #1198

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Add tests for the colortbl package, and update its code #1198

wants to merge 1 commit into from

Conversation

dpvc
Copy link
Member

@dpvc dpvc commented Feb 4, 2025

This PR adds tests for the colortbl package. The ColortblConfiguration.ts file adds lines 98-100 to skip over an mstyle that may have been added to set the scriptlevel for the table. The comments from the configuration object itself are move to before it so that prettier can be run on the configuration.

@dpvc dpvc requested a review from zorkow February 4, 2025 20:31
@dpvc dpvc added this to the v4.0 milestone Feb 4, 2025
Base automatically changed from update-test-framework to develop February 25, 2025 20:55
zorkow
zorkow approved these changes Feb 26, 2025
View reviewed changes
Copy link
Member

@zorkow zorkow left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zorkow zorkow zorkow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@dpvc @zorkow