Update begingroup tests #1205
Open
Update begingroup tests #1205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…utput. Colorize texReporter output, and format it more like jest's main output
|
I have a look at this, once merge conflicts are resolved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because this PR requires both the
begingroupbranch and theupdate-test-frameworkbranch, I've based it on theupdate-test-frameworkbranch and mergedbegingroupinto it. The target branch here isbegingroupso that you get the difference from that branch. Unfortunately, that means that all the changed fromsetupTexare listed here as well. You can ignore all the files other than theBegingroup.test.tsfile, as that is the only one actually changed here, and that is just some formatting and changes to useexpectTexError()from the newsetupTex.tsfile rather than the home-grown version here (which is actually what inspired the one insetupTex.ts).