Merge branch 'develop' into dbkr/dont_hang_up_calls_that_didnt_start

.eslintrc.js

@@ -85,5 +85,14 @@ module.exports = {
             // We use a `logger` intermediary module
             "no-console": "error",
         },
+    }, {
+        files: [
+            "spec/**/*.ts",
+        ],
+        rules: {
+            // We don't need super strict typing in test utilities
+            "@typescript-eslint/explicit-function-return-type": "off",
+            "@typescript-eslint/explicit-member-accessibility": "off",
+        },
     }],
 };

.github/workflows/static_analysis.yml

@@ -72,3 +72,38 @@ jobs:
           path: _docs
           # We'll only use this in a workflow_run, then we're done with it
           retention-days: 1
+
+  tsc-strict:
+    name: Typescript Strict Error Checker
+    if: github.event_name == 'pull_request'
+    runs-on: ubuntu-latest
+    permissions:
+      pull-requests: read
+      checks: write
+    steps:
+      - uses: actions/checkout@v3
+
+      - name: Get diff lines
+        id: diff
+        uses: Equip-Collaboration/[email protected]
+        with:
+          include: '["\\.tsx?$"]'
+
+      - name: Detecting files changed
+        id: files
+        uses: futuratrepadeira/[email protected]
+        with:
+          repo-token: ${{ secrets.GITHUB_TOKEN }}
+          pattern: '^.*\.tsx?$'
+
+      - uses: t3chguy/typescript-check-action@main
+        with:
+          repo-token: ${{ secrets.GITHUB_TOKEN }}
+          use-check: false
+          check-fail-mode: added
+          output-behaviour: annotate
+          ts-extra-args: '--noImplicitAny'
+          files-changed: ${{ steps.files.outputs.files_updated }}
+          files-added: ${{ steps.files.outputs.files_created }}
+          files-deleted: ${{ steps.files.outputs.files_deleted }}
+          line-numbers: ${{ steps.diff.outputs.lineNumbers }}

package.json

@@ -99,12 +99,12 @@
     "eslint-config-google": "^0.14.0",
     "eslint-import-resolver-typescript": "^3.5.1",
     "eslint-plugin-import": "^2.26.0",
-    "eslint-plugin-matrix-org": "^0.7.0",
+    "eslint-plugin-matrix-org": "^0.8.0",
     "eslint-plugin-unicorn": "^44.0.2",
     "exorcist": "^2.0.0",
     "fake-indexeddb": "^4.0.0",
     "jest": "^29.0.0",
-    "jest-environment-jsdom": "^28.1.3",
+    "jest-environment-jsdom": "^29.0.0",
     "jest-localstorage-mock": "^2.4.6",
     "jest-mock": "^29.0.0",
     "matrix-mock-request": "^2.5.0",

spec/integ/matrix-client-syncing.spec.ts

@@ -709,11 +709,11 @@ describe("MatrixClient syncing", () => {
                 const room = client!.getRoom(roomOne)!;
                 const stateAtStart = room.getLiveTimeline().getState(EventTimeline.BACKWARDS)!;
                 const startRoomNameEvent = stateAtStart.getStateEvents('m.room.name', '');
-                expect(startRoomNameEvent.getContent().name).toEqual('Old room name');
+                expect(startRoomNameEvent!.getContent().name).toEqual('Old room name');
 
                 const stateAtEnd = room.getLiveTimeline().getState(EventTimeline.FORWARDS)!;
                 const endRoomNameEvent = stateAtEnd.getStateEvents('m.room.name', '');
-                expect(endRoomNameEvent.getContent().name).toEqual('A new room name');
+                expect(endRoomNameEvent!.getContent().name).toEqual('A new room name');
             });
         });
 
@@ -1599,7 +1599,7 @@ describe("MatrixClient syncing", () => {
             expect(room.roomId).toBe(roomOne);
             expect(room.getMyMembership()).toBe("leave");
             expect(room.name).toBe("Room Name");
-            expect(room.currentState.getStateEvents("m.room.name", "").getId()).toBe("$eventId");
+            expect(room.currentState.getStateEvents("m.room.name", "")?.getId()).toBe("$eventId");
             expect(room.timeline[0].getContent().body).toBe("Message 1");
             expect(room.timeline[1].getContent().body).toBe("Message 2");
             client?.stopPeeking();

spec/unit/embedded.spec.ts

@@ -179,7 +179,7 @@ describe("RoomWidgetClient", () => {
             // It should've also inserted the event into the room object
             const room = client.getRoom("!1:example.org");
             expect(room).not.toBeNull();
-            expect(room!.currentState.getStateEvents("org.example.foo", "bar").getEffectiveEvent()).toEqual(event);
+            expect(room!.currentState.getStateEvents("org.example.foo", "bar")?.getEffectiveEvent()).toEqual(event);
         });
 
         it("backfills", async () => {
@@ -195,7 +195,7 @@ describe("RoomWidgetClient", () => {
 
             const room = client.getRoom("!1:example.org");
             expect(room).not.toBeNull();
-            expect(room!.currentState.getStateEvents("org.example.foo", "bar").getEffectiveEvent()).toEqual(event);
+            expect(room!.currentState.getStateEvents("org.example.foo", "bar")?.getEffectiveEvent()).toEqual(event);
         });
     });
 

spec/unit/room-state.spec.ts

@@ -152,7 +152,7 @@ describe("RoomState", function() {
         it("should return a single MatrixEvent if a state_key was specified",
             function() {
                 const event = state.getStateEvents("m.room.member", userA);
-                expect(event.getContent()).toMatchObject({
+                expect(event?.getContent()).toMatchObject({
                     membership: "join",
                 });
             });

src/ReEmitter.ts

@@ -22,7 +22,7 @@ import { EventEmitter } from "events";
 import { ListenerMap, TypedEventEmitter } from "./models/typed-event-emitter";
 
 export class ReEmitter {
-    constructor(private readonly target: EventEmitter) {}
+    public constructor(private readonly target: EventEmitter) {}
 
     // Map from emitter to event name to re-emitter
     private reEmitters = new Map<EventEmitter, Map<string, (...args: any[]) => void>>();
@@ -38,7 +38,7 @@ export class ReEmitter {
             // We include the source as the last argument for event handlers which may need it,
             // such as read receipt listeners on the client class which won't have the context
             // of the room.
-            const forSource = (...args: any[]) => {
+            const forSource = (...args: any[]): void => {
                 // EventEmitter special cases 'error' to make the emit function throw if no
                 // handler is attached, which sort of makes sense for making sure that something
                 // handles an error, but for re-emitting, there could be a listener on the original
@@ -74,7 +74,7 @@ export class TypedReEmitter<
     Events extends string,
     Arguments extends ListenerMap<Events>,
 > extends ReEmitter {
-    constructor(target: TypedEventEmitter<Events, Arguments>) {
+    public constructor(target: TypedEventEmitter<Events, Arguments>) {
         super(target);
     }
 

src/ToDeviceMessageQueue.ts

@@ -31,7 +31,7 @@ export class ToDeviceMessageQueue {
     private retryTimeout: ReturnType<typeof setTimeout> | null = null;
     private retryAttempts = 0;
 
-    constructor(private client: MatrixClient) {
+    public constructor(private client: MatrixClient) {
     }
 
     public start(): void {