Make local echo work for threads #2026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
November 19, 2021 08:33
turt2live
requested changes
Nov 23, 2021
src/client.ts
Outdated
| ): Promise<ISendEventResponse> { | ||
| return this.sendCompleteEvent(roomId, { type: eventType, content }, txnId, callback); | ||
| if (!threadId?.startsWith("$") && threadId !== null) { |
There was a problem hiding this comment.
I'm really not a fan of string matching these things - can we pass an object of some kind for instanceof checks instead? The types will be a lot easier to work with.
There was a problem hiding this comment.
They could be, but the reason why I opted out from that was to keep it simple to send an event.
Not requiring a developer to instanciate 5 different models before they can even send something
The way the app is architectured too, the composer is not really aware of the Thread model either, but is aware of a relation to attach to all event it emits out.
I decided to go with that solution to keep the door open to more changes in the future and not tie down the composer to the current model of threads
turt2live
approved these changes
Nov 23, 2021
skyka13711
pushed a commit
to 42-px/matrix-js-sdk
that referenced
this pull request
Apr 14, 2022
skyka13711
pushed a commit
to 42-px/matrix-js-sdk
that referenced
this pull request
Apr 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to element-hq/element-web#19616
This PR currently has no changelog labels, so will not be included in changelogs.
Add one of:
T-Deprecation,T-Enhancement,T-Defect,T-Taskto indicate what type of change this is plusX-Breaking-Changeif it's a breaking change.