Replace Sass variables with custom properties - mx_Indicator

[luixxiul]

Cherry-picked from #10495
For element-hq/element-web#21656

This PR intends to replace Sass variables of mx_Indicator with custom properties.

mx_Indicator on _RoomView.pcss belongs to RoomHeaderButtons.tsx, and the class name should be fixed to make it follow the naming policy, but fixing it is out of scope of this PR. It will be addressed with another PR.

type: task

Signed-off-by: Suguru Hirahara [email protected]

Checklist

• Tests written for new code (and old code if feasible)
• Linter and other CI checks pass
• Sign-off given on the changes (see CONTRIBUTING.md)

---

This change is marked as an internal change (Task), so will not be included in the changelog.

[andybalaam]

Great, thanks!

[luixxiul]

I am not really satisfied with this type of "solution". Instead there should be one common Indicator component, which could be customized with custom properties for each case. I guess it should be a better way of using the custom properties, so that cascading works effectively, keeping the number of properties as low as possible.

[luixxiul]

@andybalaam would you kindly add the PR to the queue again?

[andybalaam]

Hmm. Looks like Sliding sync: should send unsubscribe_rooms for every room switch could be flaky. If it happens again let's log a bug for it.

[andybalaam]

Percy changes approved, and the SonarCloud failure was "no artifacts found" which should be fixed now by #10863 so re-running merge.

[andybalaam]

I approved the percy changes, so am hoping this will merge.

[andybalaam]

One more try. If not, we will need to figure out why this won't pass Percy.

[luixxiul]

@andybalaam thank you for having kept an eye on this issue all day long…

[andybalaam]

I don't know why this keeps failing Percy. Asking in the development room.

[luixxiul]

Thank you for taking care of this :-)

[andybalaam]

I can't figure out why this change (and not others) is failing to merge, so I'm forcing it.