Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Delabs hidden read receipts #6941

Conversation

SimonBrandner
Copy link
Contributor

@SimonBrandner SimonBrandner commented Oct 13, 2021

Fixes element-hq/element-web#2527
Type: enhancement
Notes: Add option to stop sending read receipts (Security and Privacy -> Privacy -> Presence -> Send read receipts)
Requires matrix-org/matrix-js-sdk#1978 and element-hq/element-web#19386


Screenshot_20211025_093730

This PR moves Send read receipts setting out of labs into Security and Privacy -> Privacy -> Presence. It also moves Send typing notification from Preferences into Security and Privacy -> Privacy -> Presence for consistency. In general, I believe a user would look into Privacy when looking for how to disable these things.

It could be beneficial to add a paragraph of text below the Presence header the same way we have for Analytics to explain to the user what Presence is though I don't feel like I should be the one to write that 😅

Screenshot_20211025_093810

When the server doesn't support disabling read receipts, the settings is disabled and we show a tooltip on hover.


Here's what your changelog entry will look like:

✨ Features

Preview: https://6176721ac0a89f3530e4c49c--matrix-react-sdk.netlify.app
⚠️ Do you trust the author of this PR? Maybe this build will steal your keys or give you malware. Exercise caution. Use test accounts.

@github-actions github-actions bot added the T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements label Oct 13, 2021
@SimonBrandner SimonBrandner force-pushed the feature/delabs-hidden-rrs branch from 05e6772 to f0429bd Compare October 16, 2021 11:19
@aaronraimist
Copy link
Contributor

Rather than hiding the option when the server doesn't support the feature, I think it makes more sense to show it but have it disabled. When it is entirely missing it is hard for people to figure out why. If it was just disabled, ideally with a sentence like "Your server doesn't support this feature." then it gives people an idea of why they can't use it.

Example of someone being confused:

ok, that did the trick, I have lab settings now, but I don't have that "don't send read receipts" in the lab settings tab
should it be there or should it be somewhere else?

https://matrix.to/#/!ehXvUhWNASUkSLvAGP:matrix.org/$O33w_6lEpVQENEatuGozOHEKn9l1apCQw_9bj7aQd9s?via=matrix.org&via=matrix.breakpointingbad.com&via=libera.chat

@aaronraimist
Copy link
Contributor

aaronraimist commented Oct 25, 2021

You have also put the option inside of if (Analytics.canEnable() || CountlyAnalytics.instance.canEnable()) { so users on instances without analytics can't turn off read receipts. I think it would make more sense to place this option next to the existing "Show read receipts sent by other users" option.

@SimonBrandner SimonBrandner force-pushed the feature/delabs-hidden-rrs branch 3 times, most recently from 5e28837 to c47e683 Compare October 25, 2021 07:44
@SimonBrandner
Copy link
Contributor Author

@aaronraimist, I've updated the PR, let me know if stuff is better this way

Signed-off-by: Šimon Brandner <[email protected]>
Signed-off-by: Šimon Brandner <[email protected]>
Signed-off-by: Šimon Brandner <[email protected]>
Signed-off-by: Šimon Brandner <[email protected]>
@aaronraimist
Copy link
Contributor

Looks good to me.

Unrelated to this PR but I only just noticed, it is a bit strange that the "Manually verify all remote sessions" option is not grouped with the other encryption settings. Filed element-hq/element-web#19500 for that.

@SimonBrandner
Copy link
Contributor Author

Closing as the MSC has changed quite a bit

@SimonBrandner SimonBrandner deleted the feature/delabs-hidden-rrs branch May 1, 2022 10:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option to stop sending read receipts to other users
2 participants