-
-
Notifications
You must be signed in to change notification settings - Fork 827
Delabs hidden read receipts #6941
Delabs hidden read receipts #6941
Conversation
05e6772
to
f0429bd
Compare
Rather than hiding the option when the server doesn't support the feature, I think it makes more sense to show it but have it disabled. When it is entirely missing it is hard for people to figure out why. If it was just disabled, ideally with a sentence like "Your server doesn't support this feature." then it gives people an idea of why they can't use it. Example of someone being confused:
|
You have also put the option inside of |
5e28837
to
c47e683
Compare
@aaronraimist, I've updated the PR, let me know if stuff is better this way |
Signed-off-by: Šimon Brandner <[email protected]>
Signed-off-by: Šimon Brandner <[email protected]>
Signed-off-by: Šimon Brandner <[email protected]>
Signed-off-by: Šimon Brandner <[email protected]>
Signed-off-by: Šimon Brandner <[email protected]>
Signed-off-by: Šimon Brandner <[email protected]>
c47e683
to
c2b0a54
Compare
Looks good to me. Unrelated to this PR but I only just noticed, it is a bit strange that the "Manually verify all remote sessions" option is not grouped with the other encryption settings. Filed element-hq/element-web#19500 for that. |
Closing as the MSC has changed quite a bit |
Fixes element-hq/element-web#2527
Type: enhancement
Notes: Add option to stop sending read receipts (
Security and Privacy
->Privacy
->Presence
->Send read receipts
)Requires matrix-org/matrix-js-sdk#1978 and element-hq/element-web#19386
This PR moves
Send read receipts
setting out of labs intoSecurity and Privacy
->Privacy
->Presence
. It also movesSend typing notification
fromPreferences
intoSecurity and Privacy
->Privacy
->Presence
for consistency. In general, I believe a user would look intoPrivacy
when looking for how to disable these things.It could be beneficial to add a paragraph of text below the
Presence
header the same way we have forAnalytics
to explain to the user whatPresence
is though I don't feel like I should be the one to write that 😅When the server doesn't support disabling read receipts, the settings is disabled and we show a tooltip on hover.
Here's what your changelog entry will look like:
✨ Features
Security and Privacy
->Privacy
->Presence
->Send read receipts
) (#6941). Fixes Option to stop sending read receipts to other users element-hq/element-web#2527. Contributed by @SimonBrandner.Preview: https://6176721ac0a89f3530e4c49c--matrix-react-sdk.netlify.app
⚠️ Do you trust the author of this PR? Maybe this build will steal your keys or give you malware. Exercise caution. Use test accounts.