This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Add option to not send read receipts. #821
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
this is blocked on element-hq/riot-meta#66 |
turt2live
force-pushed
the
travis/dont-send-read-receipts
branch
from
f020f21 to
75f06cd
Compare
Addresses element-hq/element-web#2527. The side effect of this is that notifications remain stuck. Because the RR isn't sent, the unread notification stays on the client. This also ends up affecting riot-android, and likely riot-ios. Signed-off-by: Travis Ralston <[email protected]>
turt2live
force-pushed
the
travis/dont-send-read-receipts
branch
from
75f06cd to
0c1c686
Compare
|
Closing this as element-hq/riot-meta#66 doesn't seem to be on the radar for the short term. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses element-hq/element-web#2527.
Part of the metabug: element-hq/riot-meta#66
The side effect of this is that notifications remain stuck. Because the RR isn't sent, the unread notification stays on the client. This also ends up affecting riot-android, and likely riot-ios.
Signed-off-by: Travis Ralston [email protected]
NOTE: This does leave stuck notifications in riot-web and riot-android. @ara4n mentioned on element-hq/element-web#2527 that riot-ios is immune to this problem.
Here's an example in riot-web:
(pictured: Reading notifications in offtopic)