Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a static location for the Riot logo #120

Merged
merged 2 commits into from
Mar 6, 2019
Merged

Use a static location for the Riot logo #120

merged 2 commits into from
Mar 6, 2019

Conversation

turt2live
Copy link
Member

@turt2live turt2live commented Mar 1, 2019 •
edited
Loading

See element-hq/element-web#9006

Requires riot.im changes - see timeline Deployed

@turt2live turt2live marked this pull request as ready for review March 5, 2019 17:32
@turt2live turt2live requested a review from a team March 5, 2019 17:33
richvdh
richvdh approved these changes Mar 6, 2019
View reviewed changes
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but how can we stop this happening again?

@turt2live
Copy link
Member Author

will continue the conversation starting at matrix-org/synapse#4779 (comment)

@turt2live turt2live merged commit 89c3deb into master Mar 6, 2019
@turt2live turt2live deleted the travis/icons branch March 6, 2019 22:11
This was referenced Mar 6, 2019
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richvdh richvdh richvdh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@turt2live @richvdh