Split out static auth methods from Auth object #1810
Conversation
| def check(self, event, auth_events, do_sig_check=True): | ||
| class Auther(object): | ||
| @staticmethod | ||
| def check(event, auth_events, do_sig_check=True): |
There was a problem hiding this comment.
Would it make sense to make these top level functions rather than staticmethods?
There was a problem hiding this comment.
Maybe? Would you prefer that? I somewhat like having all the helper functions for check bundled together
There was a problem hiding this comment.
I would prefer that. I would also prefer it we took this opportunity to move the event auth functions to a separate file.
There was a problem hiding this comment.
(which would go someway towards separating the code for authing CS interactions from code for authing events)
| with Measure(self.clock, "auth.check"): | ||
| Auther.check(event, auth_events, do_sig_check=do_sig_check) | ||
|
|
||
| def check_size_limits(self, event): |
There was a problem hiding this comment.
Isn't check_size_limits defined as a staticmethod on the Auther class above?
| @@ -975,54 +562,7 @@ def compute_auth_events(self, event, current_state_ids, for_verification=False): | |||
| defer.returnValue(auth_ids) | |||
|
|
|||
| def _get_send_level(self, etype, state_key, auth_events): | |||
There was a problem hiding this comment.
Is _get_send_level called from anywhere? I can't see a reference to it.
Part of #1808