Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Fix sync bug when accepting invites #4903

Closed
wants to merge 3 commits into from
Closed

Fix sync bug when accepting invites #4903

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e72ccac
Fix sync bug when accepting invites
richvdh Mar 20, 2019
470e14e
Fix for the non-worker case
richvdh Mar 20, 2019
f91c178
fix again
richvdh Mar 20, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/4903.bugfix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix sync bug which made accepting invites unreliable in worker-mode synapses.
4 changes: 3 additions & 1 deletion synapse/replication/slave/storage/events.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,4 +118,6 @@ def invalidate_caches_for_event(self, stream_ordering, event_id, room_id,
self._membership_stream_cache.entity_has_changed(
state_key, stream_ordering
)
self.get_invited_rooms_for_user.invalidate((state_key,))
if not backfilled:
self.get_invited_rooms_for_user.invalidate((state_key,))
self.get_rooms_for_user_with_stream_ordering.invalidate((state_key,))
5 changes: 0 additions & 5 deletions synapse/storage/_base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1355,11 +1355,6 @@ def _invalidate_state_caches(self, room_id, members_changed):
members_changed (iterable[str]): The user_ids of members that have
changed
"""
for member in members_changed:
self._attempt_to_invalidate_cache(
"get_rooms_for_user_with_stream_ordering", (member,),
)

for host in set(get_domain_from_id(u) for u in members_changed):
self._attempt_to_invalidate_cache(
"is_host_joined", (room_id, host,),
Expand Down