This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Move some rest endpoints to client reader #5063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikjohnston
force-pushed
the
erikj/move_endpoints
branch
from
cb5677b to
f3b6cba
Compare
erikjohnston
force-pushed
the
erikj/move_endpoints
branch
from
f3b6cba to
2082519
Compare
richvdh
reviewed
Apr 15, 2019
| @@ -109,12 +112,12 @@ def _listen_http(self, listener_config): | |||
| ThreepidRestServlet(self).register(resource) | |||
| KeyQueryServlet(self).register(resource) | |||
| KeyChangesServlet(self).register(resource) | |||
| VoipRestServlet(self).register(resource) | |||
| PushRuleRestServlet(self).register(resource) | |||
There was a problem hiding this comment.
surely you can only safely move GET /pushrules to the worker?
Codecov Report
@@ Coverage Diff @@
## develop #5063 +/- ##
==========================================
- Coverage 61.57% 60.8% -0.77%
==========================================
Files 332 332
Lines 34265 34228 -37
Branches 5648 5647 -1
==========================================
- Hits 21097 20811 -286
- Misses 11654 11874 +220
- Partials 1514 1543 +29 |
richvdh
approved these changes
Apr 15, 2019
synapse/rest/client/v1/push_rule.py
Outdated
| @@ -103,6 +107,9 @@ def on_PUT(self, request): | |||
|
|
|||
| @defer.inlineCallbacks | |||
| def on_DELETE(self, request): | |||
| if self._is_worker: | |||
| raise Exception("Cannot handle PUT /push_rules on worker") | |||
erikjohnston
force-pushed
the
erikj/move_endpoints
branch
from
548fb07 to
ec638a1
Compare
This was referenced Apr 16, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.