Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Docker option for additional id server #5224

Closed

Conversation

Kolatzek
Copy link

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a changelog file
  • Pull request includes a sign off

Docker part only.

Signed-off-by: Robert Kolatzek [email protected]

Kolatzek added 2 commits May 21, 2019 17:36
Add "SYNAPSE_ADDITIONAL_ID_SERVER" in trusted_third_party_id_servers as third, optional variable (for mxisd
 users).
Documentation of SYNAPSE_ADDITIONAL_ID_SERVER
@richvdh richvdh changed the title Synapse additional id server Docker option for additional id server May 22, 2019
@richvdh
Copy link
Member

richvdh commented May 22, 2019

guess this addresses #5194.

We need to figure out what we are doing with this sort of thing (and #5206). We've previously rejected such PRs on the grounds that people should write their own config files instead, but we keep getting them.

@richvdh richvdh requested a review from a team May 22, 2019 11:56
@hawkowl
Copy link
Contributor

hawkowl commented Jun 25, 2019

We've decided we're going to go the config file route from now on #5518, and as such I'm going to close this PR.

@hawkowl hawkowl closed this Jun 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants