fix minor unreachable code caused by t.Fatal

[Abirdcfly]

Signed-off-by: Abirdcfly [email protected]

What type of PR is this?

• API-change
• BUG
• Improvement
• Documentation
• Feature
• Test and CI
• Code Refactoring

Which issue(s) this PR fixes:

issue #

What this PR does / why we need it:

[CLAassistant]

All committers have signed the CLA.

[lni]

@Abirdcfly your lint tool is pretty cool. why don't you just upstream it? ;)

[Abirdcfly]

I use revive, but after recent practice, I found some false positives here (not errors reported as errors)

$ go install github.com/mgechev/revive@master

$ cat revive-config-unreach.toml
ignoreGeneratedHeader = false
severity = "warning"
confidence = 0.8
errorCode = 0
warningCode = 0

[rule.unreachable-code]

$ revive -config revive-config-unreach.toml -exclude ./vendor/... ./...

[lni]

I use revive, but after recent practice, I found some false positives here (not errors reported as errors)

$ go install github.com/mgechev/revive@master

$ cat revive-config-unreach.toml
ignoreGeneratedHeader = false
severity = "warning"
confidence = 0.8
errorCode = 0
warningCode = 0

[rule.unreachable-code]

$ revive -config revive-config-unreach.toml -exclude ./vendor/... ./...

Thanks for the PR.

We briefly talked about revive within the team last week, seems to be a very decent SCA tool, haven't got chance to get it deployed. Care to send in a PR to help setting up revive for this project? That will be super useful.

We have all our static check stuff in the Makefile, the install-static-check-tools target installs required tools, you need to get a selected version of revive installed in that target. Actual checks is done in the static-check target. Configuration files for those static check tools are kept in the root of the repo.

Looking forward to your PR. ;)